Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[swift2objc] Support properties that throw #1939

Merged
merged 2 commits into from
Jan 28, 2025
Merged

[swift2objc] Support properties that throw #1939

merged 2 commits into from
Jan 28, 2025

Conversation

AmrAhmed119
Copy link
Contributor

@AmrAhmed119 AmrAhmed119 commented Jan 23, 2025 •
edited
Loading

Closes #1765

  • Adding support for throwing properties in swift by converting them into ordinary methods.
  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@google-cla Google CLA
Copy link

google-cla bot commented Jan 23, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@AmrAhmed119 AmrAhmed119 changed the title [swift2objc] Support properties that throw #1765 [swift2objc] Support properties that throw Jan 23, 2025
@github-actions GitHub Actions
Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️ 
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@coveralls
Copy link

coveralls commented Jan 27, 2025 •
edited
Loading

Coverage Status

coverage: 87.09% (-1.3%) from 88.352%
when pulling d274520 on AmrAhmed119:throwing-properties
into 7a72868 on dart-lang:main.

liamappelbe
liamappelbe approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@liamappelbe liamappelbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and all the tests are passing. Thanks for your contribution!

@liamappelbe liamappelbe merged commit 3229cfb into dart-lang:main Jan 28, 2025
15 checks passed
@AmrAhmed119 AmrAhmed119 deleted the throwing-properties branch January 30, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamappelbe liamappelbe liamappelbe approved these changes

Assignees
No one assigned
Labels
package:swift2objc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[swift2objc] Support properties that throw
3 participants
@AmrAhmed119 @coveralls @liamappelbe